[PATCH] D23885: [ThinLTO] add constArgumentsBitmask to caller summary

[Piotr Padlewski via llvm-commits]

Prazek added inline comments.

================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:244
@@ +243,3 @@
+/// Specific info about the call site, like the info about the arguments.
+struct CallsiteInfo {
+  /// if n_th bit is set, it means that n_th argument is constant.
----------------
tejohnson wrote:
> Since we are accumulating the info for all callsites, there isn't a reason to keep this in a separate structure from CalleeInfo. I.e. the profile counts are accumulated in CalleeInfo, even though that is essentially also callsite info.  If we decide to keep a separate edge per callsite eventually, the CalleeInfo struct will simply change to a CallsiteInfo struct and we would remove CallsiteCount. So better to have this info in CalleeInfo directly.
oh I see, it doesn't matter what caller calls with constants as long as the info is accumulated only in one module.


https://reviews.llvm.org/D23885