[PATCH] D23672: Start reifying error descriptions

[Filipe Cabecinhas via llvm-commits]

filcab added inline comments.

================
Comment at: lib/asan/asan_errors.h:50
@@ +49,3 @@
+  ErrorKind kind;
+  // (filcab): I'd rather avoid inheritance + virtual functions since that makes
+  // the type non-trivially copiable. I would like to have the same structures
----------------
kcc wrote:
> Sorry, I did not mean to literally copy the discussion into the comments.
> The comment should not be in a form of discussion, but in a form of statement. 
> 
> // We do X because Y and Z
Wow, that was especially lazy. I've rewritten the comment now. I think it contains the main points.


https://reviews.llvm.org/D23672