[PATCH] D23677: [AArch64] Avoid materializing constant values when generating csel instructions.

[Chad Rosier via llvm-commits]

mcrosier marked 2 inline comments as done.

================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:4002
@@ -4001,3 +4001,3 @@
         // If our operands are only 32-bit wide, make sure we use 32-bit
         // arithmetic for the check whether we can use CSINC. This ensures that
         // the addition in the check will wrap around properly in case there is
----------------
Deferring this work for another day.

================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:4005
@@ -4004,3 +4004,3 @@
         // an overflow (which would not be the case if we do the check with
         // 64-bit arithmetic).
         const uint32_t TrueVal32 = CTVal->getZExtValue();
----------------
Again, deferring this for now.


https://reviews.llvm.org/D23677