[polly] r279813 - Improve documentation and testing of APIntFromVal

[Michael Kruse via llvm-commits]

2016-08-26 17:51 GMT+02:00 Tobias Grosser <tobias at grosser.es>:
> On Fri, Aug 26, 2016, at 05:36 PM, Michael Kruse via llvm-commits wrote:
>> Since this commit, I get the following error on running ninja
>> check-polly-unittests:
>>
>> -- Testing: 2 tests, 2 threads --
>> FAIL: Polly-Unit :: isl/IslTests.exe/Isl.IslValToAPInt (2 of 2)
>> ******************** TEST 'Polly-Unit ::
>> isl/IslTests.exe/Isl.IslValToAPInt' FAILED ********************
>> Note: Google Test filter = Isl.IslValToAPInt
>> [==========] Running 1 test from 1 test case.
>> [----------] Global test environment set-up.
>> [----------] 1 test from Isl
>> [ RUN      ] Isl.IslValToAPInt
>> C:\Users\Meinersbur\src\llvm\tools\polly\unittests\Isl\IslTest.cpp(143):
>> error: Value of: (1ull << 60) - 1
>>   Actual: 1152921504606846975
>> Expected: APLargeNum
>> Which is: 16-byte object <21-00 00-00 D9-01 00-00 FF-FF FF-FF 00-00
>> 00-00>
>> C:\Users\Meinersbur\src\llvm\tools\polly\unittests\Isl\IslTest.cpp(144):
>> error: Value of: 61u
>>   Actual: 61
>> Expected: APLargeNum.getBitWidth()
>> Which is: 33
>> [  FAILED  ] Isl.IslValToAPInt (0 ms)
>> [----------] 1 test from Isl (0 ms total)
>>
>> [----------] Global test environment tear-down
>> [==========] 1 test from 1 test case ran. (0 ms total)
>> [  PASSED  ] 0 tests.
>> [  FAILED  ] 1 test, listed below:
>> [  FAILED  ] Isl.IslValToAPInt
>>
>>  1 FAILED TEST
>>
>> ********************
>>
>> Testing Time: 0.01s
>> ********************
>> Failing Tests (1):
>>     Polly-Unit :: isl/IslTests.exe/Isl.IslValToAPInt
>>
>>   Expected Passes    : 1
>>   Unexpected Failures: 1
>> FAILED: tools/polly/test/CMakeFiles/check-polly-unittests
>>
>> This is because isl_val_int_from_ui takes an 'unsigned long', which is
>> 32 bits on 32-bit and LLP64 systems (Windows).
>
> Thank you for reporting and tracking this down. Does r279824 resolve the
> issue?

Yes, it does. Thank you.

Michael