[PATCH] D23799: [ESan][MIPS] Adds support for MIPS64

[Sagar Thakur via llvm-commits]

slthakur added inline comments.

================
Comment at: lib/esan/esan_shadow.h:127
@@ +126,3 @@
+  {0xaa00000000u, 0xab00000000u, false},
+  {0xff00000000u, 0xffffffffffu, true},
+};
----------------
bruening wrote:
> The final 2 aren't adjacent, so I don't understand why they would be merged?
Yes, the last two don't need to be merged.

================
Comment at: lib/sanitizer_common/sanitizer_linux_mips64.S:20
@@ +19,3 @@
+        syscall
+        nop
+
----------------
bruening wrote:
> Why a nop?
Sorry a nop is not required there. I felt that a syscall would require a delay slot but thats not the case.


Repository:
  rL LLVM

https://reviews.llvm.org/D23799