[PATCH] D23834: [AArch64] Allow label arithmetic with add/sub/cmp

[Diana Picus via llvm-commits]

rovka updated this revision to Diff 69348.
rovka added a comment.

- Address Saleem's comment (thanks!)
- Get Darwin to error out on invalid values obtained from label arithmetic, i.e. negative values or values that are too large to fit. I did this by overriding the processFixupValue method in DarwinAArch64AsmBackend. It now calls adjustFixupValue with a legitimate MCContext, so it can dump errors (just like the ELF backend does).


https://reviews.llvm.org/D23834

Files:
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64MachObjectWriter.cpp
  test/MC/AArch64/basic-a64-diagnostics.s
  test/MC/AArch64/label-arithmetic-darwin.s
  test/MC/AArch64/label-arithmetic-diags-darwin.s
  test/MC/AArch64/label-arithmetic-diags-elf.s
  test/MC/AArch64/label-arithmetic-elf.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23834.69348.patch
Type: text/x-patch
Size: 14793 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160826/9dbbf8bb/attachment.bin>