[PATCH] D23910: Improve documentation and testing of APIntFromVal

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 00:19:15 PDT 2016


grosser created this revision.
grosser added a reviewer: Meinersbur.
grosser added subscribers: llvm-commits, pollydev.

The recent unit tests we gained made clear that the semantics of APIntFromVal
are not clear, due to missing documentation. In this change we document both
the calling interface as well as the implementation of APIntFromVal. We also
make the implementation easier to read by removing the use of magic numbers.
Finally, we add tests to check the bitwidth of the created values as well as
the correct modeling of very large numbers.

https://reviews.llvm.org/D23910

Files:
  include/polly/Support/GICHelper.h
  lib/Support/GICHelper.cpp
  unittests/Isl/IslTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23910.69323.patch
Type: text/x-patch
Size: 7149 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160826/ca732df3/attachment.bin>


More information about the llvm-commits mailing list