[PATCH] D23672: Start reifying error descriptions
Kostya Serebryany via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 25 17:35:58 PDT 2016
kcc added inline comments.
================
Comment at: lib/asan/asan_errors.h:52
@@ +51,3 @@
+ ErrorStackOverflow stack_overflow;
+ };
+ ErrorDescription() { internal_memset(this, 0, sizeof(*this)); }
----------------
At the very least -- move this paragraph into a comment.
================
Comment at: lib/asan/asan_report.cc:311
@@ +310,3 @@
+ // Can only report one error per ScopedInErrorReport.
+ CHECK(current_error_.kind == kErrorKindInvalid);
+ current_error_ = description;
----------------
use CHECK_EQ
https://reviews.llvm.org/D23672
More information about the llvm-commits
mailing list