[PATCH] D23889: [LV] Scalarize instructions marked scalar after vectorization

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 13:36:37 PDT 2016


hfinkel added a subscriber: hfinkel.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4550
@@ +4549,3 @@
+
+    // Scalarize instructions that should remain scalar after vectorization.
+    if (!(isa<BranchInst>(&I) || isa<PHINode>(&I)) &&
----------------
mkuper wrote:
> This scares me a bit. :-)
> As I said on the PR, I definitely think we should do it, but it still scares me. Perhaps add a bit more testing?
> 
> Regardless, there's (at least?) one more special case I see below - DbgInfoIntrinsic. 
> As I said on the PR, I definitely think we should do it, but it still scares me. Perhaps add a bit more testing?

Which PR?


https://reviews.llvm.org/D23889





More information about the llvm-commits mailing list