[PATCH] D23688: AMDGPU/SI: Implement a custom MachineSchedStrategy

[Marek Olšák via llvm-commits]

mareko added a comment.

In https://reviews.llvm.org/D23688#525512, @arsenm wrote:

> In https://reviews.llvm.org/D23688#525511, @mareko wrote:
>
> > In https://reviews.llvm.org/D23688#525486, @arsenm wrote:
> >
> > > In https://reviews.llvm.org/D23688#525484, @mareko wrote:
> > >
> > > > For shader type = VS, please don't take the LDS size into account. The LDS size is unknown at compile time and it's almost always much less than what's declared.
> > >
> > >
> > > This is only accounting for the known static LDS, there's no reason to special case this
> >
> >
> > What is the "known static LDS"?
>
>
> The declared. if you mean these shaders are creating a huge LDS array and don't intend to use it, they should switch to passing in a local pointer argument


What would the LLVM IR look like in this case? Do we have tests exercising LDS passed in a pointer argument?


https://reviews.llvm.org/D23688