[PATCH] D23499: [InstCombine] Preserve llvm.mem.parallel_loop_access metadata when replacing memcpy with ld/st

[Michael Kuperstein via llvm-commits]

mkuper added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/mem-par-metadata-memcpy.ll:13
@@ +12,3 @@
+
+; RUN: opt < %s -instcombine -S | FileCheck %s
+; CHECK: for.body:
----------------
Can you move the RUN line to be the first line in the file, before the docs?

================
Comment at: llvm/test/Transforms/InstCombine/mem-par-metadata-memcpy.ll:15
@@ +14,3 @@
+; CHECK: for.body:
+; CHECK-NOT  %{{.*}} = load i16, i16* %{{.*}}, align 1
+; CHECK  %{{.*}} = load i16, i16* %{{.*}}, align 1, !llvm.mem.parallel_loop_access !1
----------------
You're missing a ":" at the end of your CHECKs and CHECK-NOTs.
But I think if you actually add them, the test will fail, since the CHECK-NOT will match the beginning of the longer line. You'll need to rewrite the pattern to match a full line (adding a {{$}} should work), but even then, I'm not entirely sure this will do the right thing.


https://reviews.llvm.org/D23499