[PATCH] D23755: cmake: Add an ordering dep between HTML & man Sphinx targets

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 11:26:20 PDT 2016


beanz added a comment.

The simple Ninja solution is actually to just specify `USES_TERMINAL` on the target creation which will limit one at a time.

If we do that, then this dependency could be added only for non-ninja generators.

  diff --git a/cmake/modules/AddSphinxTarget.cmake b/cmake/modules/AddSphinxTarget.cmake
  index 045dc23..fbe4f95 100644
  --- a/cmake/modules/AddSphinxTarget.cmake
  +++ b/cmake/modules/AddSphinxTarget.cmake
  @@ -24,7 +24,8 @@ function (add_sphinx_target builder project)
                               "${CMAKE_CURRENT_SOURCE_DIR}" # Source
                               "${SPHINX_BUILD_DIR}" # Output
                       COMMENT
  -                    "Generating ${builder} Sphinx documentation for ${project} into \"${SPHINX_BUILD_DIR}\"")
  +                    "Generating ${builder} Sphinx documentation for ${project} into \"${SPHINX_BUILD_DIR}\""
  +                    USES_TERMINAL)
   
     # When "clean" target is run, remove the Sphinx build directory
     set_property(DIRECTORY APPEND PROPERTY


https://reviews.llvm.org/D23755





More information about the llvm-commits mailing list