[PATCH] D21723: [RFC] Enhance synchscope representation

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 10:49:17 PDT 2016


mehdi_amini added inline comments.

================
Comment at: docs/LangRef.rst:2164
@@ +2163,3 @@
+If an atomic operation is marked ``singlethread``, it only *synchronizes with*,
+and only participates in the seq\_cst total orderings, of other operations
+running in the same thread (for example, in signal handlers).
----------------
I feel the "of" should be before the comma?

================
Comment at: docs/LangRef.rst:2175
@@ +2174,3 @@
+are members (for example, in languages such as OpenCL that support separate
+memory scopes for device, work-group and sub-group).
+
----------------
It is not clear to me why we need to specify this level of details? It seems opaque to optimizer anyway.
I'll defer to Sanjoy and/or Hal for this.


https://reviews.llvm.org/D21723





More information about the llvm-commits mailing list