[PATCH] D23671: libLLVMSupport: Generate random block of arbitrary size
Aaron Ballman via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 25 08:13:03 PDT 2016
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Some minor nits, but LGTM
================
Comment at: RandomNumberGenerator.cpp:68
@@ +67,3 @@
+ HCRYPTPROV hProvider;
+ if (CryptAcquireContextW(&hProvider, 0, 0, PROV_RSA_FULL,
+ CRYPT_VERIFYCONTEXT | CRYPT_SILENT)) {
----------------
No need to specify the W version explicitly here. You can pass `nullptr` rather than `0` as well.
================
Comment at: Unix/Unix.h:52
@@ +51,3 @@
+#ifdef HAVE_FCNTL_H
+#include <fcntl.h>
+#endif
----------------
Formatting of this line doesn't match the formatting of the other lines in the file.
https://reviews.llvm.org/D23671
More information about the llvm-commits
mailing list