[PATCH] D23792: IR: Properly handle escape characters in Attribute::getAsString()
Honggyu Kim via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 25 06:08:14 PDT 2016
honggyu.kim added a comment.
In https://reviews.llvm.org/D23792#524931, @rjmccall wrote:
> These should have the same behavior; only, the existing code should be slightly more efficient (without optimization) because it knows that it's only adding a single character rather than possible an array of them. Are you actually seeing different behavior at runtime?
>
> John.
Hi John,
You're right. I've updated it by using existing PrintEscapedString() as you explained. I've tested it with mcount.c and gnu-mcount.c, and they're all passed.
I appreciate your guide!
Honggyu
https://reviews.llvm.org/D23792
More information about the llvm-commits
mailing list