[PATCH] D21232: Add attribute noreturn to functions that throw

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 20:04:26 PDT 2016


sebpop added inline comments.

================
Comment at: libcxx/include/regex:964
@@ -962,3 +963,3 @@
 _LIBCPP_ALWAYS_INLINE
 void __throw_regex_error()
 {
----------------
Why throw_regex_error is just "_LIBCPP_ALWAYS_INLINE"
whereas throw_future_error was declared as "inline _LIBCPP_ALWAYS_INLINE"?

I think we need to add inline as well before throw_regex_error.


https://reviews.llvm.org/D21232





More information about the llvm-commits mailing list