[llvm] r279699 - Update a comment.

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 18:29:55 PDT 2016


Author: gbiv
Date: Wed Aug 24 20:29:55 2016
New Revision: 279699

URL: http://llvm.org/viewvc/llvm-project?rev=279699&view=rev
Log:
Update a comment.

r279696, which changed `LLVM_CONSTEXPR AliasAttr` to `const AliasAttr`,
made this comment make less sense.

Modified:
    llvm/trunk/lib/Analysis/AliasAnalysisSummary.cpp

Modified: llvm/trunk/lib/Analysis/AliasAnalysisSummary.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/AliasAnalysisSummary.cpp?rev=279699&r1=279698&r2=279699&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/AliasAnalysisSummary.cpp (original)
+++ llvm/trunk/lib/Analysis/AliasAnalysisSummary.cpp Wed Aug 24 20:29:55 2016
@@ -15,9 +15,8 @@ const unsigned AttrFirstArgIndex = 4;
 const unsigned AttrLastArgIndex = NumAliasAttrs;
 const unsigned AttrMaxNumArgs = AttrLastArgIndex - AttrFirstArgIndex;
 
-// NOTE: These aren't AliasAttrs because bitsets don't have a constexpr
-// ctor for some versions of MSVC that we support. We could maybe refactor,
-// but...
+// It would be *slightly* prettier if we changed these to AliasAttrs, but it
+// seems that both GCC and MSVC emit dynamic initializers for const bitsets.
 using AliasAttr = unsigned;
 const AliasAttr AttrNone = 0;
 const AliasAttr AttrEscaped = 1 << AttrEscapedIndex;




More information about the llvm-commits mailing list