[PATCH] D23861: [LLVM] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 24 18:14:03 PDT 2016
MatzeB added a subscriber: MatzeB.
================
Comment at: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp:2001-2003
@@ -1945,4 +2000,5 @@
// Read all the records for this value table.
SmallString<128> ValueName;
- while (1) {
+
+ while (true) {
BitstreamEntry Entry = Stream.advanceSkippingSubblocks();
----------------
What's the deal with these gratuitous newlines in front of loops? I like putting declarations immediately in front of loops for temporary variables only used inside the loop or values that are computed in the loop...
Repository:
rL LLVM
https://reviews.llvm.org/D23861
More information about the llvm-commits
mailing list