[PATCH] D21232: Add attribute noreturn to functions that throw

[Marshall Clow via llvm-commits]

mclow.lists added a comment.

With that one change libc++ compiles and passes all it's tests
LGTM!


================
Comment at: libcxx/include/future:517
@@ -517,2 +516,3 @@
+_LIBCPP_NORETURN void __throw_future_error(future_errc _Ev)
 {
 #ifndef _LIBCPP_NO_EXCEPTIONS
----------------
This one, too - needs to be: `_LIBCPP_NORETURN inline _LIBCPP_ALWAYS_INLINE`

Which compiler are you using to test these patches?



https://reviews.llvm.org/D21232