[PATCH] D21232: Add attribute noreturn to functions that throw

[Marshall Clow via llvm-commits]

mclow.lists added inline comments.

================
Comment at: libcxx/include/__locale:1187
@@ -1186,3 +1186,3 @@
 
-_LIBCPP_FUNC_VIS void __throw_runtime_error(const char*);
+_LIBCPP_FUNC_VIS void __throw_runtime_error(const char*) _LIBCPP_NORETURN_ON_EXCEPTIONS;
 
----------------
Also, I'm pretty sure that the `_LIBCPP_NORETURN` needs to go on the beginning, not the end.



https://reviews.llvm.org/D21232