[PATCH] D23836: [ThinLTO/gold] Add caching support to gold-plugin

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 10:38:53 PDT 2016


mehdi_amini added inline comments.

================
Comment at: llvm/trunk/tools/gold/gold-plugin.cpp:812
@@ -801,1 +811,3 @@
+          *LTOOutput(OutputName).getStream() << Buffer->getBuffer();
+        });
   };
----------------
I just noticed: this is largely suboptimal, the Buffer will be a mmap'd file in memory, and you're duplicating it here.


Repository:
  rL LLVM

https://reviews.llvm.org/D23836





More information about the llvm-commits mailing list