[PATCH] D23562: [RISCV 5/10] Add bare-bones RISC-V MCTargetDesc

[Jordy Potman via llvm-commits]

jordy.potman.lists added a subscriber: jordy.potman.lists.

================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVELFObjectWriter.cpp:40
@@ +39,3 @@
+                                            bool IsPCRel) const {
+  // determine the type of the relocation
+  switch ((unsigned)Fixup.getKind()) {
----------------
Nit: The LLVM Coding Standards say that comments should use proper capitalization, punctuation, etc.: http://llvm.org/docs/CodingStandards.html#commenting

================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVMCCodeEmitter.cpp:47-48
@@ +46,4 @@
+
+  // getBinaryCodeForInstr - TableGen'erated function for getting the
+  // binary encoding for an instruction.
+  uint64_t getBinaryCodeForInstr(const MCInst &MI,
----------------
Nit: The LLVM Coding Standards say not to duplicate method names in comments: http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments

Also applies to the method below.


https://reviews.llvm.org/D23562