[PATCH] D21232: Add attribute noreturn to functions that throw

[Marshall Clow via llvm-commits]

mclow.lists added a comment.

I'm confused here.
I thought that the goal of this patch was to add `noreturn` to functions that throw //in the case when exceptions are disabled//.
which is why I suggested the macro name `LIBCPP_NORETURN_IF_NO_EXCEPTIONS`

But that's not what the code does. It marks the functions as `noreturn` only when exceptions are **enabled**.

What are we trying to accomplish here?


https://reviews.llvm.org/D21232