[PATCH] D23834: [AArch64] Allow label arithmetic with add/sub/cmp

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 07:51:31 PDT 2016


t.p.northover added a comment.

I think the MachO logic is pretty problematic:

- Because of .subsections_via_symbols a relocation would usually be needed for 2 assembler-local symbols if there's a linker-visible one between them.
- I think ARM64_RELOC_UNSIGNED is supposed to set all bits of the data it covers, not parse and interpret the instruction it's in the middle of.

I don't think there's an appropriate MachO relocation for this either, so we probably shouldn't try.

How does the ELF logic deal with attempts to perform subtractions across sections (the equivalent of the first MachO problem)?


https://reviews.llvm.org/D23834





More information about the llvm-commits mailing list