[PATCH] D21473: [mips] Fix aui/daui/dahi/dati for MIPSR6

[Simon Dardis via llvm-commits]

sdardis added inline comments.

================
Comment at: test/MC/Disassembler/Mips/micromips64r6/valid.txt:38-39
@@ -37,4 +37,4 @@
 0xf0 0x64 0x00 0x05 # CHECK: daui $3, $4, 5
-0x42 0x23 0x00 0x04 # CHECK: dahi $3, 4
-0x42 0x03 0x00 0x04 # CHECK: dati $3, 4
+0x42 0x23 0x00 0x04 # CHECK: dahi $17, $17, 4
+0x42 0x03 0x00 0x04 # CHECK: dati $16, $16, 4
 0x59 0x26 0x30 0xec # CHECK: dext $9, $6, 3, 7
----------------
dsanders wrote:
> This doesn't look correct to me. I haven't double-checked the encodings but there's only one bit different between the two instructions yet two things are different in the assembly (dahi->dati, and $16 -> $17)
> 
> Also, could you comment on why it isn't $3 any more?
The change was due to a bug in the decoder, it was reading the minor opcode as the register for microMIPS64r6. MIPSR6 has the fields swapped in comparison.


https://reviews.llvm.org/D21473