[PATCH] D23829: [ELF] - Use std::regex instead of hand written logic in elf::globMatch()

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Strings.cpp:33
@@ +32,3 @@
+  std::string T;
+  while (!S.empty()) {
+    if (S[0] == '*')
----------------
grimar wrote:
> ruiu wrote:
> > This converts "[*]" to "[.*]" which is wrong.
> Before this patch we did not have support of "[" or "]". This patch does not add any testcases as well as does not add support for them.
> I am assuming that testcases and support for new wildcard characters should be added separately.
The real problem here is that is converts ".foo" to ".foo" (unchanged), what is incorrect. I`ll add testcase and fix that.







https://reviews.llvm.org/D23829