[PATCH] D23803: [ELF] - Fix for: PR29093 - version script does not support [chars] wildcards
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 24 01:25:29 PDT 2016
grimar added a comment.
In https://reviews.llvm.org/D23803#523883, @ruiu wrote:
> Please take a look at https://reviews.llvm.org/D23827. This is a proof-of-concept patch to do glob pattern matching using std::regex. This needs to be improved (creating regex instance is expensive, so you want to do it only once for each glob pattern instead of doing it in globMatch), but I think you can get the idea.
There is one problem with it:
"If the syntax used in the sequence of characters has some syntax error, the constructor throws a regex_error exception.". Not sure how we going to handle this ?
https://reviews.llvm.org/D23803
More information about the llvm-commits
mailing list