[PATCH] D23716: [ELF] Linkerscript: allow adding start/end symbols to arbitrary section

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:316
@@ +315,3 @@
+// of regular input input sections, therefore our way of defining symbols for
+// regular
+// sections will not work. The approach we use for special section types is not
----------------
Format.

================
Comment at: ELF/LinkerScript.cpp:333-335
@@ +332,5 @@
+    Sym->Section = Sec;
+    Sym->Value =
+        AssignCmd->Expression(Sec->getVA() + (Start ? 0 : Sec->getSize())) -
+        Sec->getVA();
+  }
----------------
If an output section is defined as

 .eh_frame { start = .; foo.o(.eh_frame); bar = .; bar.o(.eh_frame); end = . }

then bar is silently set so that it points to the end of .eh_frame section? I think we want to print an error message for that instead.


https://reviews.llvm.org/D23716