[PATCH] D23437: [LoopInfo] Add a routine for verification by recomputation.

Michael Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 17:55:04 PDT 2016


mzolotukhin marked an inline comment as done.
mzolotukhin added a comment.

Hi,

I moved the new logic to `verify()` routine, does it look good? I'm not convinced that we need to recalculate `DT` though: we have a separate verifier for it and in my view recalculating it here would be functionality duplication to some extent. IOW I think we should rely on `DT` being correct and use verifiers to make sure it holds true; if we don't trust corresponding verifiers, we should fix them. Does it make sense?

Thanks,
Michael


https://reviews.llvm.org/D23437





More information about the llvm-commits mailing list