[PATCH] D23345: [llvm-cov] Add the project summary to each source file coverage report.

[Ying Yi via llvm-commits]

MaggieYi added inline comments.

================
Comment at: tools/llvm-cov/SourceCoverageViewHTML.cpp:552
@@ +551,3 @@
+     << tag("span", escape(getOptions().ProjectTitle, getOptions()))
+     << EndProjectTitleDiv;
+
----------------
vsk wrote:
> Does this need to be gated with a check to hasProjectTitle()?
Yes, fixed it. Thanks.

================
Comment at: tools/llvm-cov/SourceCoverageViewHTML.cpp:559
@@ +558,3 @@
+     << tag("span", escape(getOptions().CreatedTimeStr, getOptions()))
+     << EndCreatedTimeDiv;
+}
----------------
vsk wrote:
> Ditto, do we need a check here for hasCreatedTime()?
Yes, fixed it. Thanks.

================
Comment at: tools/llvm-cov/SourceCoverageViewText.cpp:225
@@ +224,3 @@
+  getOptions().colored_ostream(OS, raw_ostream::CYAN)
+      << getOptions().CreatedTimeStr << "\n";
+}
----------------
vsk wrote:
> Ditto, do we need checks here for hasProjectTitle() / hasCreatedTime()?
Yes, fixed it. Thanks.


https://reviews.llvm.org/D23345