[llvm] r278907 - [LTO] Introduce an Output class to wrap the output stream creation (NFC)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 15:03:53 PDT 2016


> On Aug 23, 2016, at 1:38 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
>> I’ll give a shot.
>> Why is it a problem in this case?
> 
> I don't think there is a practical problem is here, it is just not as
> obviously correct/safe.
> 
> Also, one of the long term ideas I used to have was to change the api
> to completely hide the name, that would allow us to use O_TMPFILE when
> available, fixing the annoying issue that we leave temporary files on
> disk with the program "crashes" (like when restarting it in a
> debugger).

OK!

Tentative patch:



I don’t have Gold to be able to check it though…

— 
Mehdi



More information about the llvm-commits mailing list