[PATCH] D18226: Codegen: Tail-duplicate during placement.

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 13:22:40 PDT 2016


davidxl added inline comments.

================
Comment at: lib/CodeGen/TailDuplicator.cpp:545
@@ -534,1 +544,3 @@
 
+  // When tail-duplicating relatively early, we shouldnt' de-normalize loops by
+  // duplicating latches, headers, or loop-predecessors. This interferes with
----------------
iteratee wrote:
> This was related to a performance regression I found. I can probably pull this out into a separate patch that gets committed at the same time. Would that be better?
Yes this should be in a different patch with different review (and test cases etc).


https://reviews.llvm.org/D18226





More information about the llvm-commits mailing list