[PATCH] D23715: Add @llvm.dbg.value entries for the phi node created by -mem2reg

[Keith Walker via llvm-commits]

keith.walker.arm added inline comments.

================
Comment at: lib/Transforms/Utils/Local.cpp:1147
@@ +1146,3 @@
+/// that has an associated llvm.dbg.decl intrinsic.
+bool llvm::ConvertDebugDeclareToDebugValue(DbgDeclareInst *DDI,
+                                           PHINode *APN, DIBuilder &Builder) {
----------------
aprantl wrote:
> What's the point of this return value? Isn't it always true?
Yes, it does always return true ..... I was just following the coding style in the preceding 2 functions which do a similar job for the load and store operations and which also always returns true.    I'll make this a void function and remove the return true values.


https://reviews.llvm.org/D23715