[PATCH] D23590: [Profile] Propagate branch metadata properly in InstCombine
David Li via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 23 09:00:36 PDT 2016
davidxl marked an inline comment as done.
================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:416
@@ -413,1 +415,3 @@
+static void SwapBranchWeights(SelectInst &SI) {
+ SmallVector<uint32_t, 3> Weights;
----------------
spatel wrote:
> "SwapBranchWeights" -> "swapBranchWeights"
>
> On 2nd thought, can we refactor/reuse copyMetadata() from LoopUnswitch.cpp instead of duplicating?
>
Refactored the APIs.
https://reviews.llvm.org/D23590
More information about the llvm-commits
mailing list