[PATCH] D23803: [ELF] - Fix for: PR29093 - version script does not support [chars] wildcards

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/SymbolTable.cpp:580
@@ -579,3 +579,3 @@
 static bool hasWildcard(StringRef S) {
-  return S.find_first_of("?*") != StringRef::npos;
+  return S.find_first_of("?*[]-^") != StringRef::npos;
 }
----------------
emaste wrote:
> not sure, just that e.g. `foo-bar` does not have a wildcard
This function is used for checking symbol names. Probably we can name it differently to avoid confusing, but what I want to say is that I think foo-bar is not a valid name for symbols and we should not do more complex checks here IMO.


https://reviews.llvm.org/D23803