[PATCH] D23803: [ELF] - Fix for: PR29093 - version script does not support [chars] wildcards

Ed Maste via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 07:57:56 PDT 2016


emaste added inline comments.

================
Comment at: ELF/SymbolTable.cpp:580
@@ -579,3 +579,3 @@
 static bool hasWildcard(StringRef S) {
-  return S.find_first_of("?*") != StringRef::npos;
+  return S.find_first_of("?*[]-^") != StringRef::npos;
 }
----------------
Should `-` and `^` be in here? They're only related to wildcards if inside of `[]`.


https://reviews.llvm.org/D23803





More information about the llvm-commits mailing list