[PATCH] D21982: [compiler-rt][XRay] Initial per-thread inmemory logging implementation

[Serge Rogatch via llvm-commits]

rSerge accepted this revision.
rSerge added a comment.
This revision is now accepted and ready to land.

Looks good to me.


================
Comment at: lib/xray/xray_inmemory_log.cc:160-164
@@ +159,7 @@
+    if (Fd == -1) {
+      Report("XRay: Failed opening temporary file '%s'; not logging events.",
+             TmpFilename);
+      return -1;
+    }
+    if (Verbosity())
+      fprintf(stderr, "XRay: Log file in '%s'\n", TmpFilename);
----------------
I meant a  x86/x86_64 system, consumer motherboards can easily have 2 sockets to install 2 different CPUs. Non-x86/x86_64 system is a harder question: a replacement for TSC/RDTSC would be needed.


https://reviews.llvm.org/D21982