[PATCH] D23713: [ELF] - Fix for PR26968 - i386 lld produces incorrect fatal error "SHF_MERGE section size must be a multiple of sh_entsize"

[George Rimar via llvm-commits]

grimar abandoned this revision.
grimar added a comment.

In https://reviews.llvm.org/D23713#522472, @emaste wrote:

> I believe we should restore https://reviews.llvm.org/rL263664:
>
> - Such objects may be rare/unlikely, but it is valid to have a mergeable section with `sh_entsize == 0`
> - Handling them as non-mergeable is explicitly valid behaviour (not merging a mergeable section is just a missed optimization)
> - The cost of https://reviews.llvm.org/rL263664 in terms of code complexity, size or run time, is trivial
>
>   That said, I don't care much either way and it's fine with me if we just close the PR. We should make an explicit decision though, not have the PR closed based on a misunderstanding.


Thanks for clarification Ed !
I agree that if we want to land something, this patch is not a option since fixes only i386,
so restore a https://reviews.llvm.org/rL263664 is probably better option, I am abadoning this one.


https://reviews.llvm.org/D23713