[compiler-rt] r279501 - [asan] Fix OOB_char on arm 32bit

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 19:58:12 PDT 2016


Author: vitalybuka
Date: Mon Aug 22 21:58:12 2016
New Revision: 279501

URL: http://llvm.org/viewvc/llvm-project?rev=279501&view=rev
Log:
[asan] Fix OOB_char on arm 32bit

Summary:
This does not actually fixes the test.
AddressSanitizer::OOB_char behavior is inconsistent but it somehow usually
works. On arm it runs more iterations than expected. And adding a new test with AddressSanitizerInterface prefix, even empty, somehow breaks OOB_char test.
So I will rename my test to make the bot green and will continue to investigate the test.

Reviewers: krasin

Subscribers: aemerson, rengolin, kubabrecka, llvm-commits, samparker

Differential Revision: https://reviews.llvm.org/D23790

Modified:
    compiler-rt/trunk/lib/asan/tests/asan_internal_interface_test.cc

Modified: compiler-rt/trunk/lib/asan/tests/asan_internal_interface_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_internal_interface_test.cc?rev=279501&r1=279500&r2=279501&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/tests/asan_internal_interface_test.cc (original)
+++ compiler-rt/trunk/lib/asan/tests/asan_internal_interface_test.cc Mon Aug 22 21:58:12 2016
@@ -13,7 +13,7 @@
 #include "asan_interface_internal.h"
 #include "asan_test_utils.h"
 
-TEST(AddressSanitizerInterface, SetShadow) {
+TEST(AddressSanitizerInternalInterface, SetShadow) {
   std::vector<char> buffer(17, 0xff);
 
   __asan_set_shadow_00((uptr)buffer.data(), buffer.size());




More information about the llvm-commits mailing list