[PATCH] D23370: [CodeGen] Rename MachineInstr::isInvariantLoad to isDereferenceableInvariantLoad. NFC

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 19:47:33 PDT 2016


hfinkel added a subscriber: hfinkel.

================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:1131
@@ +1130,3 @@
+  /// For example, loading a value from the constant pool or from the argument
+  /// area of a function if it does not change.  This should only return true if
+  /// *all* loads the instruction does are invariant (if it does multiple
----------------
The original text says, "invariant across the function", and it seems important that invariance here is restricted to during the execution of the current function body. Can/should you still capture this concept in the comment?



https://reviews.llvm.org/D23370





More information about the llvm-commits mailing list