[PATCH] D15537: limit the number of instructions per block examined by dead store elimination

[Daniel Berlin via llvm-commits]

On Mon, Aug 22, 2016 at 5:50 PM, Friedman, Eli <efriedma at codeaurora.org>
wrote:

> On 8/22/2016 11:28 AM, Daniel Berlin via llvm-commits wrote:
>
> +philip because he expressed concerns around limiting
>
> +eli
>
> Eli, i think your patch to DSE to do exact may-throw tracking is what made
> this worse.
>
> https://llvm.org/bugs/show_bug.cgi?id=29064
>
>
> I don't think it's the fault of my recent patch.
>

Okay.



> The stack trace from that bug points into MemDep, not my new code,
>

Well, to be fair, both are calling PointerMayBeCaptured, which is the
expensive part of this.


> and the patch which fixes it doesn't touch my new code.
>
> Fair enough.




> I'm not sure we should limit DSE.
>
>
> An arbitrary limit isn't exactly ideal, but there probably isn't any
> better way to fix the issue given the current algorithm used by DSE and
> MemDep.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160822/fc0e3185/attachment-0001.html>