[PATCH] D23296: [ValueTracking] Improve ValueTracking on left shift with nsw flag

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 17:06:29 PDT 2016


majnemer added inline comments.

================
Comment at: lib/Analysis/ValueTracking.cpp:799-800
@@ +798,4 @@
+    // If there is conflict between KnownZero and KnownOne, this must be an 
+    // overflowing left shift, so the shift result is undefined. We can return
+    // arbitrary values. Clear KnownZero and KnownOne bits so that other code 
+    // could propagate this undef.
----------------
Please remove "We can return arbitrary values."


https://reviews.llvm.org/D23296





More information about the llvm-commits mailing list