[PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 14:13:17 PDT 2016


timshen added a comment.

In https://reviews.llvm.org/D23730#522537, @dblaikie wrote:

> I'd sort of be inclined to remove them, then - but I leave that up to you.


It looks like people create some class, and add GraphTraits specialization for it, in the hope that others can use it, but didn't write a test. The right thing is to add the test, but I'm not going to be the one. :)

So I'll keep them.


https://reviews.llvm.org/D23730





More information about the llvm-commits mailing list