[PATCH] D23749: [NVPTX] Add NVPTXHoistAddrSpaceCast pass.

Jingyue Wu via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 12:03:29 PDT 2016


jingyue added a comment.

LGTM after you address David's comment -- A post-dominates B doesn't guarantee execution that reaches B will arrive A.


================
Comment at: llvm/test/CodeGen/NVPTX/hoist-addrspace-cast-e2e.ll:50
@@ +49,3 @@
+}
+
+!0 = !{}
----------------
I suggest add a test that checks we don't miscompile when the addrspacecast doesn't post-dominate the gep. 


https://reviews.llvm.org/D23749





More information about the llvm-commits mailing list