[llvm] r279454 - [SROA] Remove incorrect assertion
James Molloy via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 22 11:49:42 PDT 2016
Author: jamesm
Date: Mon Aug 22 13:49:42 2016
New Revision: 279454
URL: http://llvm.org/viewvc/llvm-project?rev=279454&view=rev
Log:
[SROA] Remove incorrect assertion
Confirmed with aprantl, this assertion is incorrect - code can get here (for example 80-bit FP types) and if it does it's benign. This is exposed by a completely unrelated patch of mine, so stop the compiler falling over.
Original differential: http://reviews.llvm.org/D16187
aprantl's advice to remove assertion: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160815/382129.html
Modified:
llvm/trunk/lib/Transforms/Scalar/SROA.cpp
Modified: llvm/trunk/lib/Transforms/Scalar/SROA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SROA.cpp?rev=279454&r1=279453&r2=279454&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/SROA.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/SROA.cpp Mon Aug 22 13:49:42 2016
@@ -4037,9 +4037,6 @@ bool SROA::splitAlloca(AllocaInst &AI, A
Size = std::min(Size, AbsEnd - Start);
}
PieceExpr = DIB.createBitPieceExpression(Start, Size);
- } else {
- assert(Pieces.size() == 1 &&
- "partition is as large as original alloca");
}
// Remove any existing dbg.declare intrinsic describing the same alloca.
More information about the llvm-commits
mailing list