[PATCH] D23350: Fix building builtins via plain "make"

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 09:27:50 PDT 2016


beanz added a comment.

@mstorsjo, I don't believe we should accept this patch because building compiler-rt without CMake is not supported. These files escaped my initial purge of makefiles because there were specific use cases that CMake couldn't handle. Since then we've made extensions to our CMake system to cover the missing use cases, so these files should all be removed. I've sent out a patch for review which does exactly that (https://reviews.llvm.org/D23777).

If there is a reason you're still using make instead of CMake when building the builtins, you should speak up now, because I think all use cases are covered.


https://reviews.llvm.org/D23350





More information about the llvm-commits mailing list