[PATCH] D23775: [LLD][ARM] Canonicalize output section name for .ARM.exidx sections

[Peter Smith via llvm-commits]

peter.smith created this revision.
peter.smith added reviewers: ruiu, rafael.
peter.smith added subscribers: llvm-commits, rengolin.
Herald added subscribers: samparker, aemerson.

The ARM Exception handling ABI requires that all ARM exception index table sections have a prefix of .ARM.exidx and are combined into a single contiguous block either in their own output section or as part of another output section.
    
In general clang will output a single .ARM.exidx section per object, but will use .ARM.exidx.<section name> when -ffunction-sections is used.
    
This change canonicalizes the names of sections with the .ARM.exidx prefix to just .ARM.exidx, which ensures that there is only a single output section.

This is the initial step in implementing ARM support for C++ exceptions.  

https://reviews.llvm.org/D23775

Files:
  ELF/Writer.cpp
  test/ELF/arm-exidx-output.s

Index: test/ELF/arm-exidx-output.s
===================================================================
--- /dev/null
+++ test/ELF/arm-exidx-output.s
@@ -0,0 +1,50 @@
+// RUN: llvm-mc -filetype=obj -triple=armv7a-none-linux-gnueabi %s -o %t
+// RUN: ld.lld %t -o %t2 2>&1
+// RUN: llvm-readobj -sections %t2 | FileCheck %s
+// REQUIRES: arm
+
+// Check that only a single .ARM.exidx output section is created when
+// there are input sections of the form .ARM.exidx.<section-name>. The
+// assembler creates the .ARM.exidx input sections with the .cantunwind
+// directive
+ .syntax unified
+ .section .text, "ax",%progbits
+ .globl _start
+ .align 2
+ .type _start,%function
+_start:
+ .fnstart
+ bx lr
+ .cantunwind
+ .fnend
+
+ .section .text.f1, "ax", %progbits
+ .globl f1
+ .align 2
+ .type f1,%function
+f1:
+ .fnstart
+ bx lr
+ .cantunwind
+ .fnend
+
+ .section .text.f2, "ax", %progbits
+ .globl f2
+ .align 2
+ .type f2,%function
+f2:
+ .fnstart
+ bx lr
+ .cantunwind
+ .fnend
+
+// CHECK:         Section {
+// CHECK:         Name: .ARM.exidx
+// CHECK-NEXT:    Type: SHT_ARM_EXIDX (0x70000001)
+// CHECK-NEXT:    Flags [ (0x82)
+// CHECK-NEXT:      SHF_ALLOC (0x2)
+// CHECK-NEXT:      SHF_LINK_ORDER (0x80)
+// CHECK-NEXT:    ]
+
+// CHECK-NOT:     Name: .ARM.exidx.text.f1
+// CHECK-NOT:     Name: .ARM.exidx.text.f2
Index: ELF/Writer.cpp
===================================================================
--- ELF/Writer.cpp
+++ ELF/Writer.cpp
@@ -90,7 +90,7 @@
   StringRef Name = S->getSectionName();
   for (StringRef V : {".text.", ".rodata.", ".data.rel.ro.", ".data.", ".bss.",
                       ".init_array.", ".fini_array.", ".ctors.", ".dtors.",
-                      ".tbss.", ".gcc_except_table.", ".tdata."})
+                      ".tbss.", ".gcc_except_table.", ".tdata.", ".ARM.exidx."})
     if (Name.startswith(V))
       return V.drop_back();
   return Name;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23775.68864.patch
Type: text/x-patch
Size: 1898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160822/6822fa38/attachment.bin>