[PATCH] D23603: [ELF] - Linkerscript: merge section attributes when create output section.

[George Rimar via llvm-commits]

Phabricator looks does not send notifications atm, so I`ll duplicate here my question:

Do you mean LinkerScript should have its own factory like I tried to do in D23315 ?

Best regards,
George.
________________________________________
От: Rui Ueyama <ruiu at google.com>
Отправлено: 22 августа 2016 г. 12:48
Кому: George Rimar; ruiu at google.com
Копия: evgeny.leviant at gmail.com; dccitaliano at gmail.com; llvm-commits at lists.llvm.org
Тема: Re: [PATCH] D23603: [ELF] - Linkerscript: merge section attributes when create output section.

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:1830
@@ -1826,1 +1829,3 @@
+  uintX_t Flags = ScriptConfig->HasContents ? 0 : H->sh_flags & ~SHF_GROUP &
+                                                      ~SHF_COMPRESSED;

----------------
This looks pretty tricky. Do you think you can make a change to not use OutputSectionFactory in LinkerScript first?


https://reviews.llvm.org/D23603