[PATCH] D23603: [ELF] - Linkerscript: merge section attributes when create output section.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:316
@@ -302,2 +315,3 @@
       OutSec->addSection(S);
+      updateFlags<ELFT>(OutSec, S);
     }
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > S is a `InputSectionBase<ELFT> *`. How does it work?
> > Do you mean call of updateFlags ? ArrayRef<InputSectionBase<ELFT> *> argument can be constructed from std::vector and as well as from single pointer:
> > 
> > ```
> >     /// Construct an ArrayRef from a single element.
> >     /*implicit*/ ArrayRef(const T &OneElt)
> >       : Data(&OneElt), Length(1) {}
> > 
> > ```
> Looks like it's too subtle to me.
Reimplemented.


https://reviews.llvm.org/D23603