[PATCH] D23716: [ELF] Linkerscript: allow adding start/end symbols to arbitrary section

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:313
@@ -312,2 +312,3 @@
 
-template <class ELFT> void assignOffsets(OutputSectionBase<ELFT> *Sec) {
+template <class ELFT>
+void addStartEndSymbols(OutputSectionCommand *Cmd,
----------------
I agree we need this function, but this is tricky, so this needs comments.

================
Comment at: ELF/LinkerScript.cpp:316
@@ +315,3 @@
+                        OutputSectionBase<ELFT> *Sec) {
+  auto Add = [&](SymbolAssignment *AssignCmd, bool Start) {
+    if (AssignCmd->Sym) {
----------------
`Add` is used only once, so please inline.


Repository:
  rL LLVM

https://reviews.llvm.org/D23716